Skip to content

Comments

Bowen amur logan design#65

Closed
amur-bashirov wants to merge 57 commits intoni:mainfrom
Samuelsotogit:Bowen-Amur-Logan-Design
Closed

Bowen amur logan design#65
amur-bashirov wants to merge 57 commits intoni:mainfrom
Samuelsotogit:Bowen-Amur-Logan-Design

Conversation

@amur-bashirov
Copy link
Collaborator

merged React and Blazer

@ni-github-admins
Copy link

ni-github-admins commented Feb 2, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@adamarnesen adamarnesen requested a review from jattasNI February 4, 2026 07:45
@@ -1,4 +1,4 @@
# SystemLink Enterprise Examples
# SystemLink Enterprise Examples - BYU team Branch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on the milestone of creating a PR! We'll need to iterate on this to get it to the point where it's ready to submit. Here's some high-level feedback to start with. We can talk more about it at our next meeting or you can ask follow ups here / in Teams.

  1. PRs should have clear titles and descriptions to help reviewers understand what's being included and to keep the repo's git history as informative as possible. Include links to related issues that the PR is resolving / making progress on. You can look at other recent PRs to this repo for examples (feat: Add example notebook for Asset Calibration alarms and notification #68)
  2. PRs should deliver small increments of value to help reduce the amount of time they take to review and to improve the incremental velocity of contributions. At a minimum we should split out the React and Blazor changes into separate PRs but if there are other ways you can think of to reduce the PR size even further, please do so.
  3. PRs should have a clean directory structure of only source files. It looks like this one includes some build output and generated README stuff and includes some paths that include your names and some files refer to BYU branches
  4. It's best to do a self-review and a peer-review of the PR first before moving it out of the Draft state and adding code owners. Self review means that you look through the files and make sure it makes sense. Peer review means having others from the dev team look at it and provide their feedback. That helps streamline the amount of feedback that owners like me will need to provide.

@amur-bashirov amur-bashirov deleted the Bowen-Amur-Logan-Design branch February 11, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants